sunxi: Rename bus-width related macros in H3 DRAM code
authorIcenowy Zheng <icenowy@aosc.xyz>
Sat, 3 Jun 2017 09:10:15 +0000 (17:10 +0800)
committerJagan Teki <jagan@amarulasolutions.com>
Thu, 8 Jun 2017 17:07:55 +0000 (22:37 +0530)
The DesignWare DRAM controller used by H3 and newer SoCs use a bit to
identify whether the DRAM is half-width.

As H3 itself come with 32-bit DRAM, the two modes of the bit used to be
named "MCTL_CR_32BIT" and "MCTL_CR_16BIT", but for SoCs with 16-bit DRAM
they're really 8-bit and 16-bit.

Rename the bit's macro, and also rename the variable name in
dram_sun8i_h3.c.

This commit do not add 16-bit DRAM controller support, but the support
will be introduced in next commit.

Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Tested-by: Jagan Teki <jagan@amarulasolutions.com>
arch/arm/include/asm/arch-sunxi/dram_sunxi_dw.h
arch/arm/mach-sunxi/dram_sunxi_dw.c

index 2770986b613f94e60ebbb8408614420a5f899f9e..d301ac95c3e71b038f3c2fec69139c64b5e9c8ee 100644 (file)
@@ -53,9 +53,9 @@ struct sunxi_mctl_com_reg {
 #define MCTL_CR_SEQUENTIAL     (0x1 << 15)
 #define MCTL_CR_INTERLEAVED    (0x0 << 15)
 
-#define MCTL_CR_32BIT          (0x1 << 12)
-#define MCTL_CR_16BIT          (0x0 << 12)
-#define MCTL_CR_BUS_WIDTH(x)   ((x) == 32 ? MCTL_CR_32BIT : MCTL_CR_16BIT)
+#define MCTL_CR_FULL_WIDTH     (0x1 << 12)
+#define MCTL_CR_HALF_WIDTH     (0x0 << 12)
+#define MCTL_CR_BUS_FULL_WIDTH(x)      ((x) << 12)
 
 #define MCTL_CR_PAGE_SIZE(x)   ((fls(x) - 4) << 8)
 #define MCTL_CR_ROW_BITS(x)    (((x) - 1) << 4)
index 2d12661a14d3677f45acfeb63e0146172595d61b..77fa6c28895b6f0b7e0d7079a86ff553d03a2e75 100644 (file)
@@ -28,7 +28,7 @@
 #define LINES_PER_BYTE_LANE    (BITS_PER_BYTE + 3)
 struct dram_para {
        u16 page_size;
-       u8 bus_width;
+       u8 bus_full_width;
        u8 dual_rank;
        u8 row_bits;
        const u8 dx_read_delays[NR_OF_BYTE_LANES][LINES_PER_BYTE_LANE];
@@ -440,7 +440,8 @@ static void mctl_set_cr(uint16_t socid, struct dram_para *para)
                        (struct sunxi_mctl_com_reg *)SUNXI_DRAM_COM_BASE;
 
        writel(MCTL_CR_BL8 | MCTL_CR_2T | MCTL_CR_DDR3 | MCTL_CR_INTERLEAVED |
-              MCTL_CR_EIGHT_BANKS | MCTL_CR_BUS_WIDTH(para->bus_width) |
+              MCTL_CR_EIGHT_BANKS |
+              MCTL_CR_BUS_FULL_WIDTH(para->bus_full_width) |
               (para->dual_rank ? MCTL_CR_DUAL_RANK : MCTL_CR_SINGLE_RANK) |
               MCTL_CR_PAGE_SIZE(para->page_size) |
               MCTL_CR_ROW_BITS(para->row_bits), &mctl_com->cr);
@@ -578,7 +579,7 @@ static int mctl_channel_init(uint16_t socid, struct dram_para *para)
        }
 
        /* set half DQ */
-       if (para->bus_width != 32) {
+       if (!para->bus_full_width) {
                writel(0x0, &mctl_ctl->dx[2].gcr);
                writel(0x0, &mctl_ctl->dx[3].gcr);
        }
@@ -622,7 +623,7 @@ static int mctl_channel_init(uint16_t socid, struct dram_para *para)
                    ((readl(&mctl_ctl->dx[3].gsr[0]) >> 24) & 0x1)) {
                        writel(0x0, &mctl_ctl->dx[2].gcr);
                        writel(0x0, &mctl_ctl->dx[3].gcr);
-                       para->bus_width = 16;
+                       para->bus_full_width = 0;
                }
 
                mctl_set_cr(socid, para);
@@ -758,7 +759,7 @@ unsigned long sunxi_dram_init(void)
 
        struct dram_para para = {
                .dual_rank = 0,
-               .bus_width = 32,
+               .bus_full_width = 1,
                .row_bits = 15,
                .page_size = 4096,