gpio: gpio-aspeed-sgpio: Return error if ngpios is not multiple of 8.
authorSteven Lee <steven_lee@aspeedtech.com>
Mon, 12 Jul 2021 10:03:16 +0000 (18:03 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Thu, 5 Aug 2021 19:16:54 +0000 (21:16 +0200)
Add an else-if condition in the probe function to check whether ngpios is
multiple of 8.
Per AST datasheet, numbers of available serial GPIO pins in Serial GPIO
Configuration Register must be n bytes. For instance, if n = 1, it means
AST SoC supports 8 GPIO pins.

Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-aspeed-sgpio.c

index b3d05fc..191b82a 100644 (file)
@@ -537,6 +537,10 @@ static int __init aspeed_sgpio_probe(struct platform_device *pdev)
        if (rc < 0) {
                dev_err(&pdev->dev, "Could not read ngpios property\n");
                return -EINVAL;
+       } else if (nr_gpios % 8) {
+               dev_err(&pdev->dev, "Number of GPIOs not multiple of 8: %d\n",
+                       nr_gpios);
+               return -EINVAL;
        }
 
        rc = device_property_read_u32(&pdev->dev, "bus-frequency", &sgpio_freq);