usb: phy: samsung: convert to devm_ioremap_resource()
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 26 Mar 2013 09:14:03 +0000 (14:44 +0530)
committerFelipe Balbi <balbi@ti.com>
Wed, 3 Apr 2013 07:56:27 +0000 (10:56 +0300)
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/phy/phy-samsung-usb3.c

index 54f6418..133f3d0 100644 (file)
@@ -244,11 +244,9 @@ static int samsung_usb3phy_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       phy_base = devm_request_and_ioremap(dev, phy_mem);
-       if (!phy_base) {
-               dev_err(dev, "%s: register mapping failed\n", __func__);
-               return -ENXIO;
-       }
+       phy_base = devm_ioremap_resource(dev, phy_mem);
+       if (IS_ERR(phy_base))
+               return PTR_ERR(phy_base);
 
        sphy = devm_kzalloc(dev, sizeof(*sphy), GFP_KERNEL);
        if (!sphy)