cpufreq: apple-soc: Fix an IS_ERR() vs NULL check
authorDan Carpenter <error27@gmail.com>
Mon, 27 Feb 2023 10:07:09 +0000 (13:07 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 1 Mar 2023 18:34:54 +0000 (19:34 +0100)
The of_iomap() function returns NULL if it fails.  It never returns
error pointers.  Fix the check accordingly.

Fixes: 6286bbb40576 ("cpufreq: apple-soc: Add new driver to control Apple SoC CPU P-states")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Eric Curtin <ecurtin@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/apple-soc-cpufreq.c

index c11d22f..021f423 100644 (file)
@@ -189,8 +189,8 @@ static int apple_soc_cpufreq_find_cluster(struct cpufreq_policy *policy,
        *info = match->data;
 
        *reg_base = of_iomap(args.np, 0);
-       if (IS_ERR(*reg_base))
-               return PTR_ERR(*reg_base);
+       if (!*reg_base)
+               return -ENOMEM;
 
        return 0;
 }