mmc: mmc_test: Fix removal of debugfs file
authorYe Bin <yebin10@huawei.com>
Wed, 23 Nov 2022 09:55:06 +0000 (17:55 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Fri, 25 Nov 2022 10:51:44 +0000 (11:51 +0100)
In __mmc_test_register_dbgfs_file(), we need to assign 'file', as it's
being used when removing the debugfs files when the mmc_test module is
removed.

Fixes: a04c50aaa916 ("mmc: core: no need to check return value of debugfs_create functions")
Signed-off-by: Ye Bin <yebin10@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
[Ulf: Re-wrote the commit msg]
Link: https://lore.kernel.org/r/20221123095506.1965691-1-yebin@huaweicloud.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/mmc_test.c

index 8d9bcee..155ce2b 100644 (file)
@@ -3179,7 +3179,8 @@ static int __mmc_test_register_dbgfs_file(struct mmc_card *card,
        struct mmc_test_dbgfs_file *df;
 
        if (card->debugfs_root)
-               debugfs_create_file(name, mode, card->debugfs_root, card, fops);
+               file = debugfs_create_file(name, mode, card->debugfs_root,
+                                          card, fops);
 
        df = kmalloc(sizeof(*df), GFP_KERNEL);
        if (!df) {