Turn on i18n support by default

BUG=v8:2745
R=danno@chromium.org

Review URL: https://codereview.chromium.org/23003028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/Makefile b/Makefile
index 288c257396de19895d85a6d399c520e939d5cb02..2679a5025f2749ba19a668012e8fa481c48f455b 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -124,9 +124,9 @@ endif
 ifeq ($(regexp), interpreted)
   GYPFLAGS += -Dv8_interpreted_regexp=1
 endif
-# i18nsupport=on
-ifeq ($(i18nsupport), on)
-  GYPFLAGS += -Dv8_enable_i18n_support=1
+# i18nsupport=off
+ifeq ($(i18nsupport), off)
+  GYPFLAGS += -Dv8_enable_i18n_support=0
 endif
 # arm specific flags.
 # armv7=false/true

diff --git a/Makefile.nacl b/Makefile.nacl
index 02e83ef2bca4711c5f96d48e48f6e9ad032f8df3..2c79ef113e3dbc99a9d2a669529484d42d97c92c 100644 (file)
--- a/Makefile.nacl
+++ b/Makefile.nacl
@@ -74,6 +74,9 @@ endif
 # For mksnapshot host generation.
 GYPENV += host_os=${HOST_OS}
 
+# ICU doesn't support NaCl.
+GYPENV += v8_enable_i18n_support=0
+
 NACL_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(NACL_ARCHES))
 .SECONDEXPANSION:
 # For some reason the $$(basename $$@) expansion didn't work here...

diff --git a/build/features.gypi b/build/features.gypi
index 3c6d25f7587c988b8aec9b81131781903f2e0c0b..5343284dbc987958368807f65a797af134d6a2cf 100644 (file)
--- a/build/features.gypi
+++ b/build/features.gypi
@@ -54,7 +54,7 @@
 
     # Enable ECMAScript Internationalization API. Enabling this feature will
     # add a dependency on the ICU library.
-    'v8_enable_i18n_support%': 0,
+    'v8_enable_i18n_support%': 1,
   },
   'target_defaults': {
     'conditions': [

diff --git a/build/standalone.gypi b/build/standalone.gypi
index f18333127a53cf285c861992126f221fe3352a78..3d4f8049ad2352f9dea42fa338f98254bd05716e 100644 (file)
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -36,7 +36,7 @@
     'clang%': 0,
     'visibility%': 'hidden',
     'v8_enable_backtrace%': 0,
-    'v8_enable_i18n_support%': 0,
+    'v8_enable_i18n_support%': 1,
     'msvs_multi_core_compile%': '1',
     'mac_deployment_target%': '10.5',
     'variables': {

diff --git a/samples/samples.gyp b/samples/samples.gyp
index c93deca4f44f35e122e36c578b49382c1f11d157..dfc7410070b3c46edf026caa98f92fc3da64701b 100644 (file)
--- a/samples/samples.gyp
+++ b/samples/samples.gyp
@@ -28,7 +28,7 @@
 {
   'variables': {
     'v8_code': 1,
-    'v8_enable_i18n_support%': 0,
+    'v8_enable_i18n_support%': 1,
   },
   'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
   'target_defaults': {

diff --git a/src/d8.gyp b/src/d8.gyp
index c033fd7e4e47b00108b14a5282ffc0197516202a..097abc04652fc39de72fc094ea08c5c2c670efdf 100644 (file)
--- a/src/d8.gyp
+++ b/src/d8.gyp
@@ -31,7 +31,7 @@
     'console%': '',
     # Enable support for Intel VTune. Supported on ia32/x64 only
     'v8_enable_vtunejit%': 0,
-    'v8_enable_i18n_support%': 0,
+    'v8_enable_i18n_support%': 1,
   },
   'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
   'targets': [