cyrpto/b128ops: Remove struct u128
authorPeter Zijlstra <peterz@infradead.org>
Wed, 31 May 2023 13:08:34 +0000 (15:08 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 5 Jun 2023 07:36:35 +0000 (09:36 +0200)
Per git-grep u128_xor() and its related struct u128 are unused except
to implement {be,le}128_xor(). Remove them to free up the namespace.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20230531132323.314826687@infradead.org
include/crypto/b128ops.h

index 0b8e6bc..f3b37cb 100644 (file)
 #include <linux/types.h>
 
 typedef struct {
-       u64 a, b;
-} u128;
-
-typedef struct {
        __be64 a, b;
 } be128;
 
@@ -61,20 +57,16 @@ typedef struct {
        __le64 b, a;
 } le128;
 
-static inline void u128_xor(u128 *r, const u128 *p, const u128 *q)
+static inline void be128_xor(be128 *r, const be128 *p, const be128 *q)
 {
        r->a = p->a ^ q->a;
        r->b = p->b ^ q->b;
 }
 
-static inline void be128_xor(be128 *r, const be128 *p, const be128 *q)
-{
-       u128_xor((u128 *)r, (u128 *)p, (u128 *)q);
-}
-
 static inline void le128_xor(le128 *r, const le128 *p, const le128 *q)
 {
-       u128_xor((u128 *)r, (u128 *)p, (u128 *)q);
+       r->a = p->a ^ q->a;
+       r->b = p->b ^ q->b;
 }
 
 #endif /* _CRYPTO_B128OPS_H */