thermal/drivers/tsens: Fix missing put_device error
authorGuangqing Zhu <zhuguangqing83@gmail.com>
Sun, 4 Apr 2021 12:54:31 +0000 (20:54 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 15 Apr 2021 11:21:42 +0000 (13:21 +0200)
Fixes coccicheck error:

drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call
of_find_device_by_node on line 715, but without a corresponding object
release within this function.

Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.c")
Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210404125431.12208-1-zhuguangqing83@gmail.com
drivers/thermal/qcom/tsens.c

index d8ce3a6..3c4c051 100644 (file)
@@ -755,8 +755,10 @@ int __init init_common(struct tsens_priv *priv)
                for (i = VER_MAJOR; i <= VER_STEP; i++) {
                        priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map,
                                                              priv->fields[i]);
-                       if (IS_ERR(priv->rf[i]))
-                               return PTR_ERR(priv->rf[i]);
+                       if (IS_ERR(priv->rf[i])) {
+                               ret = PTR_ERR(priv->rf[i]);
+                               goto err_put_device;
+                       }
                }
                ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor);
                if (ret)