drm/lima: fix wait pp reset timeout
authorQiang Yu <yuq825@gmail.com>
Sun, 19 Jul 2020 07:30:50 +0000 (15:30 +0800)
committerQiang Yu <yuq825@gmail.com>
Mon, 20 Jul 2020 00:46:06 +0000 (08:46 +0800)
PP bcast is marked as doing async reset after job is done.
When resume after suspend, each PP is reset individually,
so no need to reset in PP bcast resume. But I forgot to
clear the PP bcast async reset mark so call into async wait
before job run and gets timeout.

Closes: https://gitlab.freedesktop.org/lima/linux/-/issues/34
Fixes: 3446d7e9883d ("drm/lima: add resume/suspend callback for each ip")
Reviewed-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200719073050.776962-1-yuq825@gmail.com
drivers/gpu/drm/lima/lima_pp.c

index 33f01383409c0e80f8f0fd8805ce06f35cb02a77..a5c95bed08c09c580795b67327295d40357dddec 100644 (file)
@@ -271,6 +271,8 @@ void lima_pp_fini(struct lima_ip *ip)
 
 int lima_pp_bcast_resume(struct lima_ip *ip)
 {
+       /* PP has been reset by individual PP resume */
+       ip->data.async_reset = false;
        return 0;
 }