projects
/
platform
/
upstream
/
kmod.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
50f43ce
)
depmod: Don't fall back to uname on bad version
author
Laura Abbott
<labbott@fedoraproject.org>
Mon, 28 Sep 2015 22:39:14 +0000
(15:39 -0700)
committer
Lucas De Marchi
<lucas.demarchi@intel.com>
Wed, 30 Sep 2015 18:17:05 +0000
(15:17 -0300)
Currently, if a value that doesn't match a kernel version
("%u.%u") is passed in, depmod silently falls back to
using uname. Rather than try and work around the caller passing
bad data, just exit out instead.
tools/depmod.c
patch
|
blob
|
history
diff --git
a/tools/depmod.c
b/tools/depmod.c
index
348735f
..
a585d47
100644
(file)
--- a/
tools/depmod.c
+++ b/
tools/depmod.c
@@
-2476,7
+2476,11
@@
static int do_depmod(int argc, char *argv[])
}
}
- if (optind < argc && is_version_number(argv[optind])) {
+ if (optind < argc) {
+ if (!is_version_number(argv[optind])) {
+ ERR("Bad version passed %s\n", argv[optind]);
+ goto cmdline_failed;
+ }
cfg.kversion = argv[optind];
optind++;
} else {