Avoid using DateTime - Switch to DateTimeOffset (#39916)
authorMaryam Ariyan <maryam.ariyan@microsoft.com>
Sat, 25 Jul 2020 01:26:56 +0000 (18:26 -0700)
committerGitHub <noreply@github.com>
Sat, 25 Jul 2020 01:26:56 +0000 (01:26 +0000)
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
src/libraries/Microsoft.Extensions.Logging.Console/src/SimpleConsoleFormatter.cs
src/libraries/Microsoft.Extensions.Logging.Console/src/SystemdConsoleFormatter.cs

index 68aa95a..418350e 100644 (file)
@@ -45,8 +45,8 @@ namespace Microsoft.Extensions.Logging.Console
                     var timestampFormat = FormatterOptions.TimestampFormat;
                     if (timestampFormat != null)
                     {
-                        var dateTime = FormatterOptions.UseUtcTimestamp ? DateTime.UtcNow : DateTime.Now;
-                        timestamp = dateTime.ToString(timestampFormat);
+                        DateTimeOffset dateTimeOffset = FormatterOptions.UseUtcTimestamp ? DateTimeOffset.UtcNow : DateTimeOffset.Now;
+                        timestamp = dateTimeOffset.ToString(timestampFormat);
                     }
                     writer.WriteString("Timestamp", timestamp);
                     writer.WriteNumber(nameof(logEntry.EventId), eventId);
index f9452ed..f5b0571 100644 (file)
@@ -53,8 +53,8 @@ namespace Microsoft.Extensions.Logging.Console
             string timestampFormat = FormatterOptions.TimestampFormat;
             if (timestampFormat != null)
             {
-                DateTime dateTime = GetCurrentDateTime();
-                timestamp = dateTime.ToString(timestampFormat);
+                DateTimeOffset dateTimeOffset = GetCurrentDateTime();
+                timestamp = dateTimeOffset.ToString(timestampFormat);
             }
             if (timestamp != null)
             {
@@ -126,9 +126,9 @@ namespace Microsoft.Extensions.Logging.Console
             }
         }
 
-        private DateTime GetCurrentDateTime()
+        private DateTimeOffset GetCurrentDateTime()
         {
-            return FormatterOptions.UseUtcTimestamp ? DateTime.UtcNow : DateTime.Now;
+            return FormatterOptions.UseUtcTimestamp ? DateTimeOffset.UtcNow : DateTimeOffset.Now;
         }
 
         private static string GetLogLevelString(LogLevel logLevel)
index 0140adf..1916dd2 100644 (file)
@@ -57,8 +57,8 @@ namespace Microsoft.Extensions.Logging.Console
             string timestampFormat = FormatterOptions.TimestampFormat;
             if (timestampFormat != null)
             {
-                DateTime dateTime = GetCurrentDateTime();
-                textWriter.Write(dateTime.ToString(timestampFormat));
+                DateTimeOffset dateTimeOffset = GetCurrentDateTime();
+                textWriter.Write(dateTimeOffset.ToString(timestampFormat));
             }
 
             // category and event id
@@ -96,9 +96,9 @@ namespace Microsoft.Extensions.Logging.Console
             }
         }
 
-        private DateTime GetCurrentDateTime()
+        private DateTimeOffset GetCurrentDateTime()
         {
-            return FormatterOptions.UseUtcTimestamp ? DateTime.UtcNow : DateTime.Now;
+            return FormatterOptions.UseUtcTimestamp ? DateTimeOffset.UtcNow : DateTimeOffset.Now;
         }
 
         private static string GetSyslogSeverityString(LogLevel logLevel)