wifi: mt7601u: delete dead code checking debugfs returns
authorWang Jikai <wangjikai@hust.edu.cn>
Fri, 21 Apr 2023 09:22:00 +0000 (09:22 +0000)
committerKalle Valo <kvalo@kernel.org>
Fri, 5 May 2023 12:03:09 +0000 (15:03 +0300)
Smatch reports that:
drivers/net/wireless/mediatek/mt7601u/debugfs.c:130
mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid".

Debugfs code is not supposed to need error checking so instead of
changing this to if (IS_ERR()) the correct thing is to just delete
the dead code.

Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230421092200.24456-1-wangjikai@hust.edu.cn
drivers/net/wireless/mediatek/mt7601u/debugfs.c

index 230b0e1..dbddf25 100644 (file)
@@ -127,8 +127,6 @@ void mt7601u_init_debugfs(struct mt7601u_dev *dev)
        struct dentry *dir;
 
        dir = debugfs_create_dir("mt7601u", dev->hw->wiphy->debugfsdir);
-       if (!dir)
-               return;
 
        debugfs_create_u8("temperature", 0400, dir, &dev->raw_temp);
        debugfs_create_u32("temp_mode", 0400, dir, &dev->temp_mode);