Bluetooth: hci_qca: Optimized code while enabling clocks for BT SOC
authorVenkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Wed, 5 Feb 2020 10:51:43 +0000 (16:21 +0530)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 5 Feb 2020 11:49:55 +0000 (12:49 +0100)
* Directly passing clock pointer to clock code without checking for NULL
  as clock code takes care of it
* Removed the comment which was not necessary
* Updated code for return in qca_regulator_enable()

Signed-off-by: Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c

index eacc65b..8e95bfe 100644 (file)
@@ -1756,13 +1756,10 @@ static int qca_regulator_enable(struct qca_serdev *qcadev)
        power->vregs_on = true;
 
        ret = clk_prepare_enable(qcadev->susclk);
-       if (ret) {
-               /* Turn off regulators to overcome power leakage */
+       if (ret)
                qca_regulator_disable(qcadev);
-               return ret;
-       }
 
-       return 0;
+       return ret;
 }
 
 static void qca_regulator_disable(struct qca_serdev *qcadev)
@@ -1781,8 +1778,7 @@ static void qca_regulator_disable(struct qca_serdev *qcadev)
        regulator_bulk_disable(power->num_vregs, power->vreg_bulk);
        power->vregs_on = false;
 
-       if (qcadev->susclk)
-               clk_disable_unprepare(qcadev->susclk);
+       clk_disable_unprepare(qcadev->susclk);
 }
 
 static int qca_init_regulators(struct qca_power *qca,