Closes GH-85 Emit error rather than throwing.

Since "error" events will throw when unhandled anyhow, it makes no sense
to throw from an EventEmitter's method, especially for such a minor
misdemeanor as attempting to write to a non-writable stream.

diff --git a/lib/fs.js b/lib/fs.js
index 3eb31a99fc7b6c2e902ed232ac8e52f82ab980d0..8350c6159c799daded90c34d05511dfcffa554af 100644 (file)
--- a/lib/fs.js
+++ b/lib/fs.js
@@ -1027,7 +1027,8 @@ WriteStream.prototype.flush = function() {
 
 WriteStream.prototype.write = function(data) {
   if (!this.writable) {
-    throw new Error('stream not writable');
+    this.emit("error", new Error('stream not writable'));
+    return false;
   }
 
   this.drainable = true;

diff --git a/lib/tty_win32.js b/lib/tty_win32.js
index 6ca011a33300651fb20b2577257887dbf2a05c96..7aa137a09405c10cc74c34a06220e169984d63c4 100644 (file)
--- a/lib/tty_win32.js
+++ b/lib/tty_win32.js
@@ -99,7 +99,8 @@ WriteStream.prototype.isTTY = true;
 
 WriteStream.prototype.write = function(data, encoding) {
   if (!this.writable) {
-    throw new Error('stream not writable');
+    this.emit("error", new Error('stream not writable'));
+    return false;
   }
 
   if (Buffer.isBuffer(data)) {