drm/amd/powerplay: fix static checker warning for return meaningless value.
authorRex Zhu <Rex.Zhu@amd.com>
Mon, 11 Jan 2016 03:25:18 +0000 (11:25 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 13 Jan 2016 16:38:42 +0000 (11:38 -0500)
The return value should be either negative or zero, no positive.

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c

index d166fd9..ebdb43a 100644 (file)
@@ -199,7 +199,7 @@ static int tonga_send_msg_to_smc(struct pp_smumgr *smumgr, uint16_t msg)
        PP_ASSERT_WITH_CODE(
                1 == SMUM_READ_FIELD(smumgr->device, SMC_RESP_0, SMC_RESP),
                "Failed to send Previous Message.",
-               return 1);
+               );
 
        cgs_write_register(smumgr->device, mmSMC_MESSAGE_0, msg);
 
@@ -207,7 +207,7 @@ static int tonga_send_msg_to_smc(struct pp_smumgr *smumgr, uint16_t msg)
        PP_ASSERT_WITH_CODE(
                1 == SMUM_READ_FIELD(smumgr->device, SMC_RESP_0, SMC_RESP),
                "Failed to send Message.",
-               return 1);
+               );
 
        return 0;
 }
@@ -229,7 +229,7 @@ static int tonga_send_msg_to_smc_without_waiting
        PP_ASSERT_WITH_CODE(
                1 == SMUM_READ_FIELD(smumgr->device, SMC_RESP_0, SMC_RESP),
                "Failed to send Previous Message.",
-               return 0);
+               );
        cgs_write_register(smumgr->device, mmSMC_MESSAGE_0, msg);
 
        return 0;