gpio: sodaville: Use for_each_set_bit() in IRQ handler
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 6 Nov 2018 12:38:55 +0000 (14:38 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 7 Dec 2018 14:54:16 +0000 (16:54 +0200)
This simplifies and standardizes the AB IRQ handler by using
the for_each_set_bit() library function.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/gpio/gpio-sodaville.c

index 633f363..bb21214 100644 (file)
@@ -80,18 +80,15 @@ static int sdv_gpio_pub_set_type(struct irq_data *d, unsigned int type)
 static irqreturn_t sdv_gpio_pub_irq_handler(int irq, void *data)
 {
        struct sdv_gpio_chip_data *sd = data;
-       u32 irq_stat = readl(sd->gpio_pub_base + GPSTR);
+       unsigned long irq_stat = readl(sd->gpio_pub_base + GPSTR);
+       int irq_bit;
 
        irq_stat &= readl(sd->gpio_pub_base + GPIO_INT);
        if (!irq_stat)
                return IRQ_NONE;
 
-       while (irq_stat) {
-               u32 irq_bit = __fls(irq_stat);
-
-               irq_stat &= ~BIT(irq_bit);
+       for_each_set_bit(irq_bit, &irq_stat, 32)
                generic_handle_irq(irq_find_mapping(sd->id, irq_bit));
-       }
 
        return IRQ_HANDLED;
 }