crypto: stm32/hash - remove interruptible condition for dma
authorLionel Debieve <lionel.debieve@st.com>
Fri, 28 Jun 2019 11:26:55 +0000 (13:26 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 3 Jul 2019 14:15:08 +0000 (22:15 +0800)
When DMA is used, waiting for completion must not be
interruptible as it can generate an error that is not handle
by the driver. There is no need to put the completion
interruptible in this driver.

Signed-off-by: Lionel Debieve <lionel.debieve@st.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/stm32/stm32-hash.c

index 573ff3fad054e0f5a3ec10f12b470cc1d6d7af54..33a0612efa5713418c2943f8c3a6fc1a8cabc188 100644 (file)
@@ -461,8 +461,8 @@ static int stm32_hash_xmit_dma(struct stm32_hash_dev *hdev,
 
        dma_async_issue_pending(hdev->dma_lch);
 
-       if (!wait_for_completion_interruptible_timeout(&hdev->dma_completion,
-                                                      msecs_to_jiffies(100)))
+       if (!wait_for_completion_timeout(&hdev->dma_completion,
+                                        msecs_to_jiffies(100)))
                err = -ETIMEDOUT;
 
        if (dma_async_is_tx_complete(hdev->dma_lch, cookie,