s390/hypfs: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff --git a/arch/s390/hypfs/hypfs.h b/arch/s390/hypfs/hypfs.h
index 52348e0a812e8db6ccc98a23450f2c46ad823f8f..05f3f9aee5fc956a2ab299dd416e492a064acec1 100644 (file)
--- a/arch/s390/hypfs/hypfs.h
+++ b/arch/s390/hypfs/hypfs.h
@@ -43,7 +43,7 @@ int hypfs_diag0c_init(void);
 void hypfs_diag0c_exit(void);
 
 /* Set Partition-Resource Parameter */
-int hypfs_sprp_init(void);
+void hypfs_sprp_init(void);
 void hypfs_sprp_exit(void);
 
 /* debugfs interface */
@@ -69,9 +69,9 @@ struct hypfs_dbfs_file {
        struct dentry           *dentry;
 };
 
-extern int hypfs_dbfs_init(void);
+extern void hypfs_dbfs_init(void);
 extern void hypfs_dbfs_exit(void);
-extern int hypfs_dbfs_create_file(struct hypfs_dbfs_file *df);
+extern void hypfs_dbfs_create_file(struct hypfs_dbfs_file *df);
 extern void hypfs_dbfs_remove_file(struct hypfs_dbfs_file *df);
 
 #endif /* _HYPFS_H_ */

diff --git a/arch/s390/hypfs/hypfs_dbfs.c b/arch/s390/hypfs/hypfs_dbfs.c
index b9bdf5c1918e17bf350ca2f054aa45d91b486df1..f4c7dbfaf8ee9d5437eff6470a9d4d973e3dc335 100644 (file)
--- a/arch/s390/hypfs/hypfs_dbfs.c
+++ b/arch/s390/hypfs/hypfs_dbfs.c
@@ -78,14 +78,11 @@ static const struct file_operations dbfs_ops = {
        .unlocked_ioctl = dbfs_ioctl,
 };
 
-int hypfs_dbfs_create_file(struct hypfs_dbfs_file *df)
+void hypfs_dbfs_create_file(struct hypfs_dbfs_file *df)
 {
        df->dentry = debugfs_create_file(df->name, 0400, dbfs_dir, df,
                                         &dbfs_ops);
-       if (IS_ERR(df->dentry))
-               return PTR_ERR(df->dentry);
        mutex_init(&df->lock);
-       return 0;
 }
 
 void hypfs_dbfs_remove_file(struct hypfs_dbfs_file *df)
@@ -93,10 +90,9 @@ void hypfs_dbfs_remove_file(struct hypfs_dbfs_file *df)
        debugfs_remove(df->dentry);
 }
 
-int hypfs_dbfs_init(void)
+void hypfs_dbfs_init(void)
 {
        dbfs_dir = debugfs_create_dir("s390_hypfs", NULL);
-       return PTR_ERR_OR_ZERO(dbfs_dir);
 }
 
 void hypfs_dbfs_exit(void)

diff --git a/arch/s390/hypfs/hypfs_diag.c b/arch/s390/hypfs/hypfs_diag.c
index 3452e18bb1ca8a241677cab4fd761f13758531dd..f0bc4dc3e9bf0c486500840a36bdb22def45a462 100644 (file)
--- a/arch/s390/hypfs/hypfs_diag.c
+++ b/arch/s390/hypfs/hypfs_diag.c
@@ -440,11 +440,10 @@ __init int hypfs_diag_init(void)
                pr_err("The hardware system does not support hypfs\n");
                return -ENODATA;
        }
-       if (diag204_info_type == DIAG204_INFO_EXT) {
-               rc = hypfs_dbfs_create_file(&dbfs_file_d204);
-               if (rc)
-                       return rc;
-       }
+
+       if (diag204_info_type == DIAG204_INFO_EXT)
+               hypfs_dbfs_create_file(&dbfs_file_d204);
+
        if (MACHINE_IS_LPAR) {
                rc = diag224_get_name_table();
                if (rc) {

diff --git a/arch/s390/hypfs/hypfs_diag0c.c b/arch/s390/hypfs/hypfs_diag0c.c
index 9c398bf0ddc68f7b4c8a71721171d53ac8c80e5f..72e3140fafb50a9b32d347a3b0e1a7807722f5e4 100644 (file)
--- a/arch/s390/hypfs/hypfs_diag0c.c
+++ b/arch/s390/hypfs/hypfs_diag0c.c
@@ -124,7 +124,8 @@ int __init hypfs_diag0c_init(void)
 {
        if (!MACHINE_IS_VM)
                return 0;
-       return hypfs_dbfs_create_file(&dbfs_file_0c);
+       hypfs_dbfs_create_file(&dbfs_file_0c);
+       return 0;
 }
 
 /*

diff --git a/arch/s390/hypfs/hypfs_sprp.c b/arch/s390/hypfs/hypfs_sprp.c
index 601b70786dc857804d5fe263a9ef2e7c9b710502..7d9fb496d155b3dafdc6ffe6154bc063334fd7c8 100644 (file)
--- a/arch/s390/hypfs/hypfs_sprp.c
+++ b/arch/s390/hypfs/hypfs_sprp.c
@@ -137,11 +137,11 @@ static struct hypfs_dbfs_file hypfs_sprp_file = {
        .unlocked_ioctl = hypfs_sprp_ioctl,
 };
 
-int hypfs_sprp_init(void)
+void hypfs_sprp_init(void)
 {
        if (!sclp.has_sprp)
-               return 0;
-       return hypfs_dbfs_create_file(&hypfs_sprp_file);
+               return;
+       hypfs_dbfs_create_file(&hypfs_sprp_file);
 }
 
 void hypfs_sprp_exit(void)

diff --git a/arch/s390/hypfs/hypfs_vm.c b/arch/s390/hypfs/hypfs_vm.c
index c4b7b681e0554eecf0e459be2f350046ce2356fd..42f2375c203edc9a44016d6f42dee30c8b232ad9 100644 (file)
--- a/arch/s390/hypfs/hypfs_vm.c
+++ b/arch/s390/hypfs/hypfs_vm.c
@@ -279,7 +279,8 @@ int hypfs_vm_init(void)
                guest_query = local_guest;
        else
                return -EACCES;
-       return hypfs_dbfs_create_file(&dbfs_file_2fc);
+       hypfs_dbfs_create_file(&dbfs_file_2fc);
+       return 0;
 }
 
 void hypfs_vm_exit(void)

diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c
index c681329fdeec6ba42c95cb321b4ea8ae23b0df06..ccad1398abd406eba3298cc85bec320161443566 100644 (file)
--- a/arch/s390/hypfs/inode.c
+++ b/arch/s390/hypfs/inode.c
@@ -456,9 +456,8 @@ static int __init hypfs_init(void)
 {
        int rc;
 
-       rc = hypfs_dbfs_init();
-       if (rc)
-               return rc;
+       hypfs_dbfs_init();
+
        if (hypfs_diag_init()) {
                rc = -ENODATA;
                goto fail_dbfs_exit;
@@ -467,10 +466,7 @@ static int __init hypfs_init(void)
                rc = -ENODATA;
                goto fail_hypfs_diag_exit;
        }
-       if (hypfs_sprp_init()) {
-               rc = -ENODATA;
-               goto fail_hypfs_vm_exit;
-       }
+       hypfs_sprp_init();
        if (hypfs_diag0c_init()) {
                rc = -ENODATA;
                goto fail_hypfs_sprp_exit;
@@ -489,7 +485,6 @@ fail_hypfs_diag0c_exit:
        hypfs_diag0c_exit();
 fail_hypfs_sprp_exit:
        hypfs_sprp_exit();
-fail_hypfs_vm_exit:
        hypfs_vm_exit();
 fail_hypfs_diag_exit:
        hypfs_diag_exit();