client/cmdline: Fix leak found by covscan

leaked_storage: Variable "base64" going out of scope leaks the storage it points to.

diff --git a/client/common/cmdline.c b/client/common/cmdline.c
index 98421c4..386d33c 100644 (file)
--- a/client/common/cmdline.c
+++ b/client/common/cmdline.c
@@ -2596,7 +2596,7 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,
                }
                CommandLineSwitchCase(arg, "reconnect-cookie")
                {
-                       BYTE* base64;
+                       BYTE* base64 = NULL;
                        int length;
                        crypto_base64_decode((const char*)(arg->Value), (int) strlen(arg->Value),
                                             &base64, &length);
@@ -2604,12 +2604,13 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,
                        if ((base64 != NULL) && (length == sizeof(ARC_SC_PRIVATE_PACKET)))
                        {
                                memcpy(settings->ServerAutoReconnectCookie, base64, length);
-                               free(base64);
                        }
                        else
                        {
                                WLog_ERR(TAG, "reconnect-cookie:  invalid base64 '%s'", arg->Value);
                        }
+
+                       free(base64);
                }
                CommandLineSwitchCase(arg, "print-reconnect-cookie")
                {