clk: sp7021: fix return value check in sp7021_clk_probe()
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 28 Nov 2023 13:30:16 +0000 (21:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:37 +0000 (15:35 -0800)
[ Upstream commit 1004c346a2b7393fce37dd1f320555e0a0d71e3f ]

devm_platform_ioremap_resource() never returns NULL pointer,
it will return ERR_PTR() when it fails, so replace the check
with IS_ERR().

Fixes: d54c1fd4a51e ("clk: Add Sunplus SP7021 clock driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20231128133016.2494699-1-yangyingliang@huawei.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/clk-sp7021.c

index 01d3c4c..7cb7d50 100644 (file)
@@ -604,14 +604,14 @@ static int sp7021_clk_probe(struct platform_device *pdev)
        int i;
 
        clk_base = devm_platform_ioremap_resource(pdev, 0);
-       if (!clk_base)
-               return -ENXIO;
+       if (IS_ERR(clk_base))
+               return PTR_ERR(clk_base);
        pll_base = devm_platform_ioremap_resource(pdev, 1);
-       if (!pll_base)
-               return -ENXIO;
+       if (IS_ERR(pll_base))
+               return PTR_ERR(pll_base);
        sys_base = devm_platform_ioremap_resource(pdev, 2);
-       if (!sys_base)
-               return -ENXIO;
+       if (IS_ERR(sys_base))
+               return PTR_ERR(sys_base);
 
        /* enable default clks */
        for (i = 0; i < ARRAY_SIZE(sp_clken); i++)