misc: genwqe: card_base: Remove set but unused variable 'rc'
authorLee Jones <lee.jones@linaro.org>
Wed, 1 Jul 2020 08:58:49 +0000 (09:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Jul 2020 13:05:38 +0000 (15:05 +0200)
Variable 'rc' hasn't been checked since the driver's inception
in 2013.  If it hasn't caused any issues since then, it's unlikely
to in the future.  Let's take it out for now.

Fixes the following W=1 kernel build warning(s):

 drivers/misc/genwqe/card_base.c: In function ‘genwqe_health_check_stop’:
 /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
 1046 | int rc;
 | ^~

Cc: Michael Jung <mijung@gmx.net>
Cc: Michael Ruettger <michael@ibmra.de>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Joerg-Stephan Vogt <jsvogt@de.ibm.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Frank Haverkamp <haver@linux.ibm.com>
Link: https://lore.kernel.org/r/20200701085853.164358-17-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/genwqe/card_base.c

index 9969c00..0e83192 100644 (file)
@@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct genwqe_dev *cd)
 
 static int genwqe_health_check_stop(struct genwqe_dev *cd)
 {
-       int rc;
-
        if (!genwqe_health_thread_running(cd))
                return -EIO;
 
-       rc = kthread_stop(cd->health_thread);
+       kthread_stop(cd->health_thread);
        cd->health_thread = NULL;
        return 0;
 }