media: go7007: Remove redundant if statement

The if statement that compares msgs[i].len != 3 is always false because
it is in a code block where msg[i].len is equal to 3. The check is
redundant and can be removed.

As detected by cppcheck static analysis:
drivers/media/usb/go7007/go7007-i2c.c:168:20: warning: Opposite inner
'if' condition leads to a dead code block. [oppositeInnerCondition]

Link: https://lore.kernel.org/linux-media/20230727174007.635572-1-colin.i.king@gmail.com
Fixes: 866b8695d67e ("Staging: add the go7007 video driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/usb/go7007/go7007-i2c.c b/drivers/media/usb/go7007/go7007-i2c.c
index 38339dd..2880370 100644 (file)
--- a/drivers/media/usb/go7007/go7007-i2c.c
+++ b/drivers/media/usb/go7007/go7007-i2c.c
@@ -165,8 +165,6 @@ static int go7007_i2c_master_xfer(struct i2c_adapter *adapter,
                } else if (msgs[i].len == 3) {
                        if (msgs[i].flags & I2C_M_RD)
                                return -EIO;
-                       if (msgs[i].len != 3)
-                               return -EIO;
                        if (go7007_i2c_xfer(go, msgs[i].addr, 0,
                                        (msgs[i].buf[0] << 8) | msgs[i].buf[1],
                                        0x01, &msgs[i].buf[2]) < 0)