Fixed coverity issues

Change-Id: I19f27469c22bc1662c8a33afc92f3bebdc2c560d
Signed-off-by: hyunuktak <hyunuk.tak@samsung.com>

diff --git a/src/helper/helper-nfacct-rule.c b/src/helper/helper-nfacct-rule.c
index aec0ef3..bd86b01 100755 (executable)
--- a/src/helper/helper-nfacct-rule.c
+++ b/src/helper/helper-nfacct-rule.c
@@ -278,15 +278,15 @@ bool recreate_counter_by_name(char *cnt_name, nfacct_rule_s *cnt)
                iface = get_iftype_by_name(ifname_buf);
                /* check first part is it datacall */
                if (iface == STC_IFACE_DATACALL) {
-                       strncpy(cnt->ifname, ifname_buf, MAX_IFACE_LENGTH);
+                       strncpy(cnt->ifname, ifname_buf, MAX_IFACE_LENGTH - 1);
                        cnt->iotype = NFACCT_COUNTER_IN;
                } else {
                        /* +1, due : symbol and till the end of cnt_name */
-                       strncpy(ifname_buf, iftype_part + 1, MAX_IFACE_LENGTH);
+                       strncpy(ifname_buf, iftype_part + 1, MAX_IFACE_LENGTH - 1);
                        iface = get_iftype_by_name(ifname_buf);
                        if (iface == STC_IFACE_DATACALL) {
                                cnt->iotype = NFACCT_COUNTER_OUT;
-                               strncpy(cnt->ifname, ifname_buf, MAX_IFACE_LENGTH);
+                               strncpy(cnt->ifname, ifname_buf, MAX_IFACE_LENGTH - 1);
                        }
                }
 

diff --git a/src/monitor/stc-monitor.c b/src/monitor/stc-monitor.c
index a50d65b..522a615 100755 (executable)
--- a/src/monitor/stc-monitor.c
+++ b/src/monitor/stc-monitor.c
@@ -716,7 +716,7 @@ static stc_error_e __close_and_reopen_contr_sock(stc_system_s *system)
 
        /* create netlink socket for updating kernel counters */
        system->contr_sock = create_netlink(NETLINK_NETFILTER, 0);
-       if (!(system->contr_sock)) {
+       if (system->contr_sock < 0) {
                STC_LOGE("failed to open socket");
                FREE(system);
                return STC_ERROR_FAIL;
@@ -1599,7 +1599,7 @@ stc_error_e stc_monitor_init(void)
 
        /* create netlink socket for updating kernel counters */
        system->contr_sock = create_netlink(NETLINK_NETFILTER, 0);
-       if (!(system->contr_sock)) {
+       if (system->contr_sock < 0) {
                STC_LOGE("failed to open socket");
                FREE(system);
                return STC_ERROR_FAIL;