netfilter: nf_queue: Don't recompute the hook_list head
authorEric W. Biederman <ebiederm@xmission.com>
Fri, 19 Jun 2015 22:23:37 +0000 (17:23 -0500)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 2 Jul 2015 13:03:13 +0000 (15:03 +0200)
If someone sends packets from one of the netdevice ingress hooks to
the a userspace queue, and then userspace later accepts the packet,
the netfilter code can enter an infinite loop as the list head will
never be found.

Pass in the saved list_head to avoid this.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_queue.c

index cd60d39..8a8b2ab 100644 (file)
@@ -213,7 +213,7 @@ void nf_reinject(struct nf_queue_entry *entry, unsigned int verdict)
 
        if (verdict == NF_ACCEPT) {
        next_hook:
-               verdict = nf_iterate(&nf_hooks[entry->state.pf][entry->state.hook],
+               verdict = nf_iterate(entry->state.hook_list,
                                     skb, &entry->state, &elem);
        }