Use GST_ELEMENT_CAST() instead of (GstElement *)

[Version] 0.3.153
[Issue Type] Improvement

Change-Id: Id69d0ae78d8b599b6263626494bc7a743c5f59ee
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index e4cbd7b0df3fa183647c5fbc6b5a9f5f1ed523e3..3a2d30b7df66c9a369289515655eac12b74179b8 100644 (file)
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.3.152
+Version:    0.3.153
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/webrtc_private.c b/src/webrtc_private.c
index 193f5b904150c617ea8e6ca69337ea20a419d696..93848b38d8eb3ef915c2a7b02457fde2c47e243b 100644 (file)
--- a/src/webrtc_private.c
+++ b/src/webrtc_private.c
@@ -1720,15 +1720,15 @@ bool _sync_elements_state_with_parent(GList *element_list)
        RET_VAL_IF(element_list == NULL, false, "element_list is NULL");
 
        for (list = element_list; list; list = g_list_next(list))
-               RET_VAL_IF(!gst_element_sync_state_with_parent((GstElement *)list->data), false,
-                       "failed to gst_element_sync_state_with_parent(), [%s]", GST_ELEMENT_NAME((GstElement *)list->data));
+               RET_VAL_IF(!gst_element_sync_state_with_parent(GST_ELEMENT_CAST(list->data)), false,
+                       "failed to gst_element_sync_state_with_parent(), [%s]", GST_ELEMENT_NAME(GST_ELEMENT_CAST(list->data)));
 
        return true;
 }
 
 static void __foreach_unref_object_cb(gpointer data, gpointer user_data)
 {
-       GstElement *element = (GstElement *)data;
+       GstElement *element = GST_ELEMENT_CAST(data);
 
        LOG_DEBUG("%s is unreferenced", GST_ELEMENT_NAME(element));
        SAFE_GST_OBJECT_UNREF(element);
@@ -1744,7 +1744,7 @@ bool _add_elements_to_bin(GstBin *bin, GList *element_list)
        RET_VAL_IF(element_list == NULL, false, "element_list is NULL");
 
        for (list = element_list; list; list = list->next) {
-               element = (GstElement *)list->data;
+               element = GST_ELEMENT_CAST(list->data);
                if (!gst_bin_add(bin, element)) {
                        LOG_ERROR("failed to gst_bin_add(), bin[%s], element[%s]", GST_ELEMENT_NAME(bin), GST_ELEMENT_NAME(element));
                        _remove_elements_from_bin(bin, added_list);
@@ -1774,8 +1774,8 @@ bool _link_elements(GList *element_list)
        for (list = element_list; list; list = g_list_next(list)) {
                if (!g_list_previous(list))
                        continue;
-               prev = (GstElement *)(g_list_previous(list)->data);
-               curr = (GstElement *)list->data;
+               prev = GST_ELEMENT_CAST(g_list_previous(list)->data);
+               curr = GST_ELEMENT_CAST(list->data);
                RET_VAL_IF(!gst_element_link(prev, curr), false,
                        "failed to gst_element_link(), [%s] - [%s]", GST_ELEMENT_NAME(prev), GST_ELEMENT_NAME(curr));
                LOG_WARNING("[%s] - [%s]", GST_ELEMENT_NAME(prev), GST_ELEMENT_NAME(curr));
@@ -1798,7 +1798,7 @@ bool _remove_elements_from_bin(GstBin *bin, GList *element_list)
        RET_VAL_IF(element_list == NULL, false, "element_list is NULL");
 
        for (list = element_list; list; list = g_list_next(list)) {
-               element = (GstElement *)list->data;
+               element = GST_ELEMENT_CAST(list->data);
                RET_VAL_IF(!gst_bin_remove(bin, element), false,
                        "failed to gst_bin_remove(), bin[%s], element[%s]", GST_ELEMENT_NAME(bin), GST_ELEMENT_NAME(element));
                count++;

diff --git a/src/webrtc_source.c b/src/webrtc_source.c
index c5d4bb22e33fd6faa4193d5cfd7e737f3bf3e33b..bf9d87e2ff9301d02d3194c6c209d2a6e5bf0b0c 100644 (file)
--- a/src/webrtc_source.c
+++ b/src/webrtc_source.c
@@ -577,7 +577,7 @@ static bool __link_switch_srcs(GstElement *switch_element, GList *switch_src_lis
        RET_VAL_IF(switch_src_list == NULL, false, "switch_src_list is NULL");
 
        for (list = switch_src_list; list; list = g_list_next(list)) {
-               element = (GstElement *)list->data;
+               element = GST_ELEMENT_CAST(list->data);
                RET_VAL_IF(!gst_element_link(element, switch_element), false,
                        "failed to gst_element_link(), [%s] - [%s]", GST_ELEMENT_NAME(element), GST_ELEMENT_NAME(switch_element));