ASoC: cs42l42: Remove redundant writes to RS_PLUG/RS_UNPLUG masks
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 16 Nov 2021 16:38:59 +0000 (16:38 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 17 Nov 2021 13:04:44 +0000 (13:04 +0000)
The RS_PLUG and RS_UNPLUG interrupt masks are always written as 1 so
those writes are redundant and can be deleted.

This makes it completely clear in the code that only the TS_PLUG and
TS_UNPLUG masks are being changed.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20211116163901.45390-3-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs42l42.c

index 92bdc3a355ffb75b7aad2bacb7c30293c0e1758b..3674f73301dc73b4e241a4947fc3e36f31d57731 100644 (file)
@@ -1320,12 +1320,8 @@ static void cs42l42_process_hs_type_detect(struct cs42l42_private *cs42l42)
        /* Unmask tip sense interrupts */
        regmap_update_bits(cs42l42->regmap,
                CS42L42_TSRS_PLUG_INT_MASK,
-               CS42L42_RS_PLUG_MASK |
-               CS42L42_RS_UNPLUG_MASK |
                CS42L42_TS_PLUG_MASK |
                CS42L42_TS_UNPLUG_MASK,
-               (1 << CS42L42_RS_PLUG_SHIFT) |
-               (1 << CS42L42_RS_UNPLUG_SHIFT) |
                (0 << CS42L42_TS_PLUG_SHIFT) |
                (0 << CS42L42_TS_UNPLUG_SHIFT));
 }
@@ -1335,12 +1331,8 @@ static void cs42l42_init_hs_type_detect(struct cs42l42_private *cs42l42)
        /* Mask tip sense interrupts */
        regmap_update_bits(cs42l42->regmap,
                                CS42L42_TSRS_PLUG_INT_MASK,
-                               CS42L42_RS_PLUG_MASK |
-                               CS42L42_RS_UNPLUG_MASK |
                                CS42L42_TS_PLUG_MASK |
                                CS42L42_TS_UNPLUG_MASK,
-                               (1 << CS42L42_RS_PLUG_SHIFT) |
-                               (1 << CS42L42_RS_UNPLUG_SHIFT) |
                                (1 << CS42L42_TS_PLUG_SHIFT) |
                                (1 << CS42L42_TS_UNPLUG_SHIFT));