Fix diagnostic recursion ICE
authorNathan Sidwell <nathan@acm.org>
Tue, 4 Jan 2022 20:45:36 +0000 (12:45 -0800)
committerNathan Sidwell <nathan@acm.org>
Wed, 5 Jan 2022 12:04:01 +0000 (04:04 -0800)
The [with T = $TYPE] diagnostic machinery must not cause recursion. So let's
not unilaterally warn about new alignment.  (template extracted from Open3D.)

gcc/cp/
* init.c (build_new_1): Check complain before alignment warning.
gcc/testsuite/
* g++.dg/diagnostic/recur-align.C: New.

gcc/cp/init.c
gcc/testsuite/g++.dg/diagnostic/recur-align.C [new file with mode: 0644]

index 3f56ca4..9d616f3 100644 (file)
@@ -3408,7 +3408,8 @@ build_new_1 (vec<tree, va_gc> **placement, tree type, tree nelts,
     = (type_num_arguments (TREE_TYPE (alloc_fn)) > 1
        || varargs_function_p (alloc_fn));
 
-  if (warn_aligned_new
+  if (complain & tf_warning_or_error
+      && warn_aligned_new
       && !placement_allocation_fn_p
       && TYPE_ALIGN (elt_type) > malloc_alignment ()
       && (warn_aligned_new > 1
diff --git a/gcc/testsuite/g++.dg/diagnostic/recur-align.C b/gcc/testsuite/g++.dg/diagnostic/recur-align.C
new file mode 100644 (file)
index 0000000..e7d4b9a
--- /dev/null
@@ -0,0 +1,19 @@
+// ICE with diagnostic recursion
+// { dg-do compile { target { c++11_only || c++14_only } } }
+// { dg-options -Waligned-new }
+
+struct __attribute__ ((aligned(256))) Aligned
+{
+  int b;
+};
+
+template<typename T>
+auto Foo (const T* x) -> decltype (new T (*x))
+{
+  return new T (*x); // { dg-warning "with extended alignment" }
+}
+
+void Bar () {
+  Aligned y;
+  Foo (&y);
+}