platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout
authorRob Barnes <robbarnes@google.com>
Wed, 2 Aug 2023 17:58:48 +0000 (17:58 +0000)
committerTzung-Bi Shih <tzungbi@kernel.org>
Mon, 7 Aug 2023 02:39:16 +0000 (10:39 +0800)
Remove the 1 second timeout applied to hw_protection_shutdown after an
EC panic. On some platforms this 1 second timeout is insufficient to
allow the filesystem to fully sync. Independently the EC will force a
full system reset after a short period. So this backup timeout is
unnecessary.

Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20230802175847.1.Ie9fc53b6a1f4c6661c5376286a50e0cf51b3e961@changeid
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/platform/chrome/cros_ec_lpc.c

index 500a61b..3565724 100644 (file)
@@ -327,8 +327,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
                dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
                blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
                kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
-               /* Begin orderly shutdown. Force shutdown after 1 second. */
-               hw_protection_shutdown("CrOS EC Panic", 1000);
+               /* Begin orderly shutdown. EC will force reset after a short period. */
+               hw_protection_shutdown("CrOS EC Panic", -1);
                /* Do not query for other events after a panic is reported */
                return;
        }