Improve diagnostics for restore_cwd failure.

diff --git a/ChangeLog b/ChangeLog
index a4613110b0117024741580fb1e75084c4a22c2b8..0d9a067ef854da356d61688bf1abffa6e57f714f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,17 @@
 
        * Version 5.3.1.
 
+       Improve diagnostics for restore_cwd failure.
+       * src/install.c (main): Standardize on a diagnostic for
+       restore_cwd failure, and report errno.
+       (install_file_in_file_parents): Fail if restore_cwd fails and
+       one of the files is relative.  This fixes a bug (albeit unlikely).
+       * src/mkdir.c (create_parents): Remove static var (now local to 'main').
+       (main): Standardize on a diagnostic for restore_cwd failure,
+       and report errno.
+       Don't bother to check cwd_errno unless create_parents.
+       Use mkdir rather than make_dir; it's simpler.
+
        * src/install.c (main): Adjust to new make_dir_parents convention.
        * src/mkdir.c (main): Likewise.
 

diff --git a/lib/ChangeLog b/lib/ChangeLog
index fabf690288c1853ded556edfec35724e9e836430..2e0854e914d51c7c9561e65f77a5302b37d224ad 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,5 +1,13 @@
 2005-06-14  Paul Eggert  <eggert@cs.ucla.edu>
 
+       Improve quality of diagnostics on restore_cwd failure.
+       * mkdir-p.h (make_dir): Remove.  All uses replaced by mkdir.
+       (make_dir_parents): Last arg is now int * (for errno), not bool *.
+       * mkdir-p.c (make_dir, make_dir_parents): Likewise.
+       Rewrite "mkdir -p" algorithm to avoid the need for "stat"
+       each time through the loop.  Do not diagnose restore_cwd failure;
+       that is the caller's job (and perhaps the caller does not care).
+
        * mkdir-p.c (CLEANUP_CWD, CLEANUP): Remove.
        (make_dir_parents): Revamp to avoid need for CLEANUP_CWD, CLEANUP.
        If the file already exists but is not a directory, don't bother