platform/x86/intel/pmc/mtl: Put devices in D3 during resume
authorDavid E. Box <david.e.box@linux.intel.com>
Wed, 7 Jun 2023 23:38:49 +0000 (16:38 -0700)
committerHans de Goede <hdegoede@redhat.com>
Tue, 13 Jun 2023 10:30:02 +0000 (12:30 +0200)
An earlier commit placed some driverless devices in D3 during boot so that
they don't block package cstate entry on Meteor Lake. Also place these
devices in D3 after resume from suspend.

Fixes: 336ba968d3e3 ("platform/x86/intel/pmc/mtl: Put GNA/IPU/VPU devices in D3")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20230607233849.239047-2-david.e.box@linux.intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/pmc/mtl.c

index e8cc156..2b00ad9 100644 (file)
@@ -68,16 +68,29 @@ static void mtl_set_device_d3(unsigned int device)
        }
 }
 
+/*
+ * Set power state of select devices that do not have drivers to D3
+ * so that they do not block Package C entry.
+ */
+static void mtl_d3_fixup(void)
+{
+       mtl_set_device_d3(MTL_GNA_PCI_DEV);
+       mtl_set_device_d3(MTL_IPU_PCI_DEV);
+       mtl_set_device_d3(MTL_VPU_PCI_DEV);
+}
+
+static int mtl_resume(struct pmc_dev *pmcdev)
+{
+       mtl_d3_fixup();
+       return pmc_core_resume_common(pmcdev);
+}
+
 void mtl_core_init(struct pmc_dev *pmcdev)
 {
        pmcdev->map = &mtl_reg_map;
        pmcdev->core_configure = mtl_core_configure;
 
-       /*
-        * Set power state of select devices that do not have drivers to D3
-        * so that they do not block Package C entry.
-        */
-       mtl_set_device_d3(MTL_GNA_PCI_DEV);
-       mtl_set_device_d3(MTL_IPU_PCI_DEV);
-       mtl_set_device_d3(MTL_VPU_PCI_DEV);
+       mtl_d3_fixup();
+
+       pmcdev->resume = mtl_resume;
 }