radv: enable fullyCoveredFragmentShaderInputVariable on GFX9+
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 22 Feb 2023 15:36:11 +0000 (16:36 +0100)
committerMarge Bot <emma+marge@anholt.net>
Tue, 21 Mar 2023 08:44:09 +0000 (08:44 +0000)
For vkd3d-proton Tier 3.

It's passing CTS and vkd3d-proton tests.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8311
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21497>

docs/relnotes/new_features.txt
src/amd/ci/radv-navi21-aco-fails.txt
src/amd/ci/radv-vangogh-aco-fails.txt
src/amd/vulkan/radv_physical_device.c
src/amd/vulkan/radv_shader.c

index 58aafc1..60cd053 100644 (file)
@@ -1,3 +1,4 @@
 VK_EXT_pipeline_library_group_handles on RADV
 VK_EXT_image_sliced_view_of_3d on RADV/GFX10+
 VK_KHR_map_memory2 on ANV
+fullyCoveredFragmentShaderInputVariable on RADV/GFX9+
index faa38e3..91d2cb5 100644 (file)
@@ -115,3 +115,14 @@ dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers32_sets1,C
 dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers3_sets1,Crash
 dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers8_sets1,Crash
 dEQP-VK.pipeline.fast_linked_library.extended_dynamic_state.before_draw.line_stipple_enable,Fail
+
+# https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4298
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
index 979ffc1..3fce2d3 100644 (file)
@@ -117,3 +117,14 @@ dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_vert_buffers8_sets1,Cr
 dEQP-VK.binding_model.ics_miss_buffers8_sets1,Crash
 
 dEQP-VK.draw.dynamic_rendering.primary_cmd_buff.linear_interpolation.no_offset_2_samples,Fail
+
+# https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4298
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.fast_linked_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_2_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_4_post_depth_coverage,Fail
+dEQP-VK.pipeline.pipeline_library.multisample_with_fragment_shading_rate.conservative_with_full_coverage.underestimate.samples_8_post_depth_coverage,Fail
index 731974d..9871a2b 100644 (file)
@@ -1840,7 +1840,7 @@ radv_GetPhysicalDeviceProperties2(VkPhysicalDevice physicalDevice,
          properties->conservativePointAndLineRasterization = false;
          properties->degenerateTrianglesRasterized = true;
          properties->degenerateLinesRasterized = false;
-         properties->fullyCoveredFragmentShaderInputVariable = false;
+         properties->fullyCoveredFragmentShaderInputVariable = true;
          properties->conservativeRasterizationPostDepthCoverage = false;
          break;
       }
index 2ff3ca0..9c1e039 100644 (file)
@@ -716,6 +716,7 @@ radv_shader_spirv_to_nir(struct radv_device *device, const struct radv_pipeline_
                .float32_atomic_min_max = true,
                .float64 = true,
                .float64_atomic_min_max = true,
+               .fragment_fully_covered = true,
                .geometry_streams = true,
                .groups = true,
                .image_atomic_int64 = true,