jbd2: remove dead check in journal_alloc_journal_head
authorKemeng Shi <shikemeng@huaweicloud.com>
Thu, 1 Aug 2024 01:38:09 +0000 (09:38 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 27 Aug 2024 03:49:15 +0000 (23:49 -0400)
We will alloc journal_head with __GFP_NOFAIL anyway, test for failure
is pointless.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20240801013815.2393869-3-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c

index 33a975193f1f10d43fdd922c253277647c08a83f..326373ab022ae64f394cdca5296b967a6cf91ec0 100644 (file)
@@ -2866,8 +2866,7 @@ static struct journal_head *journal_alloc_journal_head(void)
                ret = kmem_cache_zalloc(jbd2_journal_head_cache,
                                GFP_NOFS | __GFP_NOFAIL);
        }
-       if (ret)
-               spin_lock_init(&ret->b_state_lock);
+       spin_lock_init(&ret->b_state_lock);
        return ret;
 }