iio: adc: fsl-imx25-gcq: adjust irq check to match docs and simplify code

For the function of platform_get_irq(), the example in platform.c is
 *	int irq = platform_get_irq(pdev, 0);
 *	if (irq < 0)
 *		return irq;
the return value of zero is unnecessary to check, so make the right
check and simplify code.

Note that platform_get_irq() is documented as never returning 0
so this is a minor optmization rather than a fix.

Co-developed-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20210802120929.33760-1-tangbin@cmss.chinamobile.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index 0c771d6..329c555 100644 (file)
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -347,14 +347,11 @@ static int mx25_gcq_probe(struct platform_device *pdev)
                goto err_vref_disable;
        }
 
-       priv->irq = platform_get_irq(pdev, 0);
-       if (priv->irq <= 0) {
-               ret = priv->irq;
-               if (!ret)
-                       ret = -ENXIO;
+       ret = platform_get_irq(pdev, 0);
+       if (ret < 0)
                goto err_clk_unprepare;
-       }
 
+       priv->irq = ret;
        ret = request_irq(priv->irq, mx25_gcq_irq, 0, pdev->name, priv);
        if (ret) {
                dev_err(dev, "Failed requesting IRQ\n");