phy: ti: j721e-wiz: add missing call to of_node_put()
authorYang Li <yang.lee@linux.alibaba.com>
Thu, 25 Feb 2021 09:17:54 +0000 (17:17 +0800)
committerVinod Koul <vkoul@kernel.org>
Tue, 30 Mar 2021 18:05:17 +0000 (23:35 +0530)
In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1614244674-66556-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-j721e-wiz.c

index 124a3ed..3c003f9 100644 (file)
@@ -1104,6 +1104,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
 
                ret = of_property_read_u32(subnode, "reg", &reg);
                if (ret) {
+                       of_node_put(subnode);
                        dev_err(dev,
                                "%s: Reading \"reg\" from \"%s\" failed: %d\n",
                                __func__, subnode->name, ret);