COMPMID-3329: failures in nightly (GC/GEMM and CPP/DFT)
authorManuel Bottini <manuel.bottini@arm.com>
Thu, 23 Apr 2020 11:40:08 +0000 (12:40 +0100)
committerMichele Di Giorgio <michele.digiorgio@arm.com>
Sun, 26 Apr 2020 12:57:50 +0000 (12:57 +0000)
- Can't recreate GC/GEMM
- Fix on CPP/DFT/DFT2D/Complex using the appropriate tolerance
- Fix CPP/DFT/Conv/Real2Real by removing concurrency issue on faulty function

Looking at the proper fix for CPP/DFT/Conv/Real2Real since it is a concurrency issue

Change-Id: Ic846dc7925d4c1b47e14181656c905f90778cdeb
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3085
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
tests/validation/CPP/DFT.cpp
tests/validation/reference/DFT.cpp

index 8f1b82371dd360e3d2374dce0f608bdb24157bfa..d4020f2d99aceb8912b9c1f04e9205428f71e2e5 100644 (file)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019 ARM Limited.
+ * Copyright (c) 2019-2020 ARM Limited.
  *
  * SPDX-License-Identifier: MIT
  *
@@ -141,7 +141,7 @@ DATA_TEST_CASE(Complex, framework::DatasetMode::ALL, shapes_2d_dft,
     auto backward = reference::dft_2d(forward, reference::FFTDirection::Inverse);
 
     // Validate with input
-    validate(SimpleTensorAccessor<float>(src), backward, RelativeTolerance<float>(0.1f));
+    validate(SimpleTensorAccessor<float>(src), backward, RelativeTolerance<float>(0.1f), 0.f, AbsoluteTolerance<float>(0.001f));
 }
 TEST_SUITE_END() // DFT2D
 
index ae030c71046d8bc71674a4082c760b6331aabd14..7221312641329db10b37ee3eda9f5b5c66e9a157 100644 (file)
@@ -269,9 +269,7 @@ SimpleTensor<T> complex_mul_and_reduce(const SimpleTensor<T> &input, const Simpl
 
     // MemSet dst memory to zero
     std::memset(dst.data(), 0, dst.size());
-#if defined(_OPENMP)
-    #pragma omp parallel for collapse(5)
-#endif /* _OPENMP */
+
     for(uint32_t b = 0; b < N; ++b)
     {
         for(uint32_t co = 0; co < Co; ++co)