Do not ignore valgrind checks returning an error
authorDodji Seketeli <dodji@redhat.com>
Fri, 24 Feb 2017 13:55:01 +0000 (14:55 +0100)
committerDodji Seketeli <dodji@redhat.com>
Mon, 27 Feb 2017 09:01:15 +0000 (10:01 +0100)
Under "make check-valgrindk", when valgrind returns errors, these
errors are ignored by make.  It turns out it is the autoconf
VALGRIND_CHECK_RULES macro that does this.  Fixed thus.

* autoconf-archive/ax_valgrind_check.m4 (check-valgrind): Don't
ignore errors.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
autoconf-archive/ax_valgrind_check.m4

index b18babe606749e66b56aaad59a33291f01e489af..d0e3c2d048e3594108133a37d6486bd8fa4b4fc6 100644 (file)
@@ -184,10 +184,12 @@ else
 valgrind_lt =
 endif
 
-# Use recursive makes in order to ignore errors during check
+# Initial comment: Use recursive makes in order to ignore errors during check
+# Dodji Comment: We do not want to ignore errors during checks.
+# We want Make to keep going as much as it can.
 check-valgrind:
 ifeq ($(VALGRIND_ENABLED),yes)
-       -$(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
+       $(A''M_V_at)$(foreach tool,$(valgrind_enabled_tools), \
                $(MAKE) $(AM_MAKEFLAGS) -k check-valgrind-$(tool); \
        )
 else