iio: imu: st_lsm6dsx: check return value from st_lsm6dsx_sensor_set_enable
authorLorenzo Bianconi <lorenzo@kernel.org>
Fri, 7 Feb 2020 12:37:54 +0000 (13:37 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 Mar 2020 17:28:28 +0000 (17:28 +0000)
Add missing return value check in st_lsm6dsx_shub_read_oneshot disabling
the slave device connected to the st_lsm6dsx i2c controller.
The issue is reported by coverity with the following error:

Unchecked return value:
If the function returns an error value, the error value may be mistaken
for a normal value.

Addresses-Coverity-ID: 1456767 ("Unchecked return value")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_shub.c

index eea5556..95ddd19 100644 (file)
@@ -464,9 +464,10 @@ st_lsm6dsx_shub_read_oneshot(struct st_lsm6dsx_sensor *sensor,
 
        len = min_t(int, sizeof(data), ch->scan_type.realbits >> 3);
        err = st_lsm6dsx_shub_read(sensor, ch->address, data, len);
+       if (err < 0)
+               return err;
 
-       st_lsm6dsx_shub_set_enable(sensor, false);
-
+       err = st_lsm6dsx_shub_set_enable(sensor, false);
        if (err < 0)
                return err;