drm/i915/fbdev: do not create fbdev if HPD is suspended
authorAndrzej Hajda <andrzej.hajda@intel.com>
Fri, 26 Aug 2022 14:19:29 +0000 (16:19 +0200)
committerImre Deak <imre.deak@intel.com>
Mon, 5 Sep 2022 13:21:46 +0000 (16:21 +0300)
In case of deferred FB setup core can try to create new
framebuffer. Disallow it if hpd_suspended flag is set.

Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220826141929.189681-4-andrzej.hajda@intel.com
drivers/gpu/drm/i915/display/intel_fbdev.c

index 8642196..b3a254c 100644 (file)
@@ -210,6 +210,12 @@ static int intelfb_create(struct drm_fb_helper *helper,
        struct drm_i915_gem_object *obj;
        int ret;
 
+       mutex_lock(&ifbdev->hpd_lock);
+       ret = ifbdev->hpd_suspended ? -EAGAIN : 0;
+       mutex_unlock(&ifbdev->hpd_lock);
+       if (ret)
+               return ret;
+
        if (intel_fb &&
            (sizes->fb_width > intel_fb->base.width ||
             sizes->fb_height > intel_fb->base.height)) {