dmaengine: qcom_hidma: Use devm_platform_get_and_ioremap_resource()
authorYangtao Li <frank.li@vivo.com>
Wed, 5 Jul 2023 08:18:53 +0000 (16:18 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Jul 2023 16:54:00 +0000 (22:24 +0530)
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Link: https://lore.kernel.org/r/20230705081856.13734-2-frank.li@vivo.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/hidma.c

index 344525c..b5e3633 100644 (file)
@@ -765,17 +765,15 @@ static int hidma_probe(struct platform_device *pdev)
        pm_runtime_set_active(&pdev->dev);
        pm_runtime_enable(&pdev->dev);
 
-       trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       trca = devm_ioremap_resource(&pdev->dev, trca_resource);
+       trca = devm_platform_get_and_ioremap_resource(pdev, 0, &trca_resource);
        if (IS_ERR(trca)) {
-               rc = -ENOMEM;
+               rc = PTR_ERR(trca);
                goto bailout;
        }
 
-       evca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       evca = devm_ioremap_resource(&pdev->dev, evca_resource);
+       evca = devm_platform_get_and_ioremap_resource(pdev, 1, &evca_resource);
        if (IS_ERR(evca)) {
-               rc = -ENOMEM;
+               rc = PTR_ERR(evca);
                goto bailout;
        }
 
@@ -785,7 +783,7 @@ static int hidma_probe(struct platform_device *pdev)
         */
        chirq = platform_get_irq(pdev, 0);
        if (chirq < 0) {
-               rc = -ENODEV;
+               rc = chirq;
                goto bailout;
        }