Fix issue #20076 createdump faults. (#20084)
authorMike McLaughlin <mikem@microsoft.com>
Fri, 21 Sep 2018 04:28:27 +0000 (21:28 -0700)
committerGitHub <noreply@github.com>
Fri, 21 Sep 2018 04:28:27 +0000 (21:28 -0700)
Return E_FAIL instead of S_FALSE from ClrDataFrame::GetLocalSig().

Also issue https://github.com/dotnet/diagnostics/issues/61

src/debug/daccess/stack.cpp

index b235366..2f69a02 100644 (file)
@@ -1257,7 +1257,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         COR_ILMETHOD_DECODER methodDecoder(m_methodDesc->GetILHeader());
@@ -1267,7 +1267,7 @@ ClrDataFrame::GetLocalSig(MetaSig** sig,
         {
             *sig = NULL;
             *count = 0;
-            return S_FALSE;
+            return E_FAIL;
         }
 
         ULONG tokenSigLen;