selftests/efivarfs: Add checking of the test return value
authorZhao Gongyi <zhaogongyi@huawei.com>
Tue, 22 Nov 2022 11:26:26 +0000 (19:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:14:02 +0000 (13:14 +0100)
[ Upstream commit c93924267fe6f2b44af1849f714ae9cd8117a9cd ]

Add checking of the test return value, otherwise it will report success
forever for test_create_read().

Fixes: dff6d2ae56d0 ("selftests/efivarfs: clean up test files from test_create*()")
Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/efivarfs/efivarfs.sh

index a90f394..d374878 100755 (executable)
@@ -87,6 +87,11 @@ test_create_read()
 {
        local file=$efivarfs_mount/$FUNCNAME-$test_guid
        ./create-read $file
+       if [ $? -ne 0 ]; then
+               echo "create and read $file failed"
+               file_cleanup $file
+               exit 1
+       fi
        file_cleanup $file
 }