[clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi...

llvm-svn: 366443

diff --git a/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp b/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
index 4bba9ce..985993a 100644 (file)
--- a/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
+++ b/clang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
@@ -128,6 +128,11 @@ public:
         TypeWithKeyword::getTagTypeKindName(Record->getTagKind()));
   }
   Intent intent() const override { return Info; }
+  // FIXME: this is interesting to most users. However:
+  //  - triggering is too broad (e.g. triggers on comments within a class)
+  //  - showMessage has inconsistent UX (e.g. newlines are stripped in VSCode)
+  //  - the output itself is a bit hard to decipher.
+  bool hidden() const override { return true; }
 
 private:
   const RecordDecl *Record = nullptr;