eeprom: at24: provide and use at24_base_client_dev()
authorBartosz Golaszewski <brgl@bgdev.pl>
Mon, 19 Mar 2018 09:17:14 +0000 (10:17 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Mar 2018 15:25:00 +0000 (16:25 +0100)
Use a helper function for accessing the device struct of the base
i2c client. This routine is named in a way that reflects its purpose
unlike the previously hand-coded dereferencing.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/at24.c

index 90adca1..633fbdb 100644 (file)
@@ -263,6 +263,11 @@ static struct at24_client *at24_translate_offset(struct at24_data *at24,
        return &at24->client[i];
 }
 
+static struct device *at24_base_client_dev(struct at24_data *at24)
+{
+       return &at24->client[0].client->dev;
+}
+
 static size_t at24_adjust_read_count(struct at24_data *at24,
                                      unsigned int offset, size_t count)
 {
@@ -374,7 +379,7 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count)
        int ret;
 
        at24 = priv;
-       dev = &at24->client[0].client->dev;
+       dev = at24_base_client_dev(at24);
 
        if (unlikely(!count))
                return count;
@@ -421,7 +426,7 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count)
        int ret;
 
        at24 = priv;
-       dev = &at24->client[0].client->dev;
+       dev = at24_base_client_dev(at24);
 
        if (unlikely(!count))
                return -EINVAL;