ALSA: usb-audio: Configure sync endpoints before data

commit 0e85a22d01dfe9ad9a9d9e87cd4a88acce1aad65 upstream.

Devices such as the TC-Helicon GoXLR require the sync endpoint to be
configured in advance of the data endpoint in order for sound output
to work.

This patch simply changes the ordering of EP configuration to resolve
this.

Fixes: bf6313a0ff76 ("ALSA: usb-audio: Refactor endpoint management")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215079
Signed-off-by: Craig McLure <craig@mclure.net>
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220524062115.25968-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 729e26f..9e65a42 100644 (file)
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -439,16 +439,21 @@ static int configure_endpoints(struct snd_usb_audio *chip,
                /* stop any running stream beforehand */
                if (stop_endpoints(subs, false))
                        sync_pending_stops(subs);
+               if (subs->sync_endpoint) {
+                       err = snd_usb_endpoint_configure(chip, subs->sync_endpoint);
+                       if (err < 0)
+                               return err;
+               }
                err = snd_usb_endpoint_configure(chip, subs->data_endpoint);
                if (err < 0)
                        return err;
                snd_usb_set_format_quirk(subs, subs->cur_audiofmt);
-       }
-
-       if (subs->sync_endpoint) {
-               err = snd_usb_endpoint_configure(chip, subs->sync_endpoint);
-               if (err < 0)
-                       return err;
+       } else {
+               if (subs->sync_endpoint) {
+                       err = snd_usb_endpoint_configure(chip, subs->sync_endpoint);
+                       if (err < 0)
+                               return err;
+               }
        }
 
        return 0;