dmaengine: xgene-dma: move spin_lock_bh to spin_lock in tasklet
authorJeff Xie <chongguiguzi@gmail.com>
Tue, 19 Mar 2019 16:45:19 +0000 (00:45 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 25 Mar 2019 16:22:28 +0000 (21:52 +0530)
It is unnecessary to call spin_lock_bh in a tasklet.

Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/xgene-dma.c

index eafd6c4..0023236 100644 (file)
@@ -703,7 +703,7 @@ static void xgene_dma_cleanup_descriptors(struct xgene_dma_chan *chan)
 
        INIT_LIST_HEAD(&ld_completed);
 
-       spin_lock_bh(&chan->lock);
+       spin_lock(&chan->lock);
 
        /* Clean already completed and acked descriptors */
        xgene_dma_clean_completed_descriptor(chan);
@@ -772,7 +772,7 @@ static void xgene_dma_cleanup_descriptors(struct xgene_dma_chan *chan)
         */
        xgene_chan_xfer_ld_pending(chan);
 
-       spin_unlock_bh(&chan->lock);
+       spin_unlock(&chan->lock);
 
        /* Run the callback for each descriptor, in order */
        list_for_each_entry_safe(desc_sw, _desc_sw, &ld_completed, node) {