KVM: Standardize on "int" return types instead of "long" in kvm_main.c
authorThomas Huth <thuth@redhat.com>
Wed, 8 Feb 2023 14:01:04 +0000 (15:01 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 16 Mar 2023 14:18:07 +0000 (10:18 -0400)
KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels.
Some code still uses "long" in unnecessary spots, though, which can
cause a little bit of confusion and unnecessary size casts. Let's
change these spots to use "int" types, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230208140105.655814-6-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
virt/kvm/kvm_main.c

index d255964ec331ef5c9aebf90243990ef4da0aec2b..f40b72eb0e7bfd699c8c9f1c8ee7adc6b6a3937d 100644 (file)
@@ -4467,7 +4467,7 @@ static int kvm_ioctl_create_device(struct kvm *kvm,
        return 0;
 }
 
-static long kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
+static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg)
 {
        switch (arg) {
        case KVM_CAP_USER_MEMORY:
@@ -5045,7 +5045,7 @@ put_fd:
 static long kvm_dev_ioctl(struct file *filp,
                          unsigned int ioctl, unsigned long arg)
 {
-       long r = -EINVAL;
+       int r = -EINVAL;
 
        switch (ioctl) {
        case KVM_GET_API_VERSION: