Fix static analysis issues

Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>

diff --git a/src/action/plugin_executor.cc b/src/action/plugin_executor.cc
index 57a9e04675ba69c6e18e7486127264cdb1db7306..7dd82f71e8830e937cf17ca9ea94d549ccbd33b2 100644 (file)
--- a/src/action/plugin_executor.cc
+++ b/src/action/plugin_executor.cc
@@ -20,8 +20,8 @@
 
 #include "common/action_model.h"
 #include "common/utils/logging.hh"
-#include "utils/action_model_converter.hh"
 #include "plugin_executor.hh"
+#include "utils/action_model_converter.hh"
 
 namespace action {
 
@@ -31,8 +31,7 @@ class ResultHandler : public rpc_port::plugin_manager_proxy::proxy::
   ResultHandler(PluginExecutor* executor)
       : rpc_port::plugin_manager_proxy::proxy::PluginManager::ResultHandler(
             true),
-        executor_(executor) {
-  }
+        executor_(executor) {}
 
   ~ResultHandler() = default;
 
@@ -47,11 +46,10 @@ class ResultHandler : public rpc_port::plugin_manager_proxy::proxy::
 
 PluginExecutor::PluginExecutor(std::string id, const common::ActionModel& model)
     : AbstractActionExecutor(std::move(id)),
+      model_(model),
       plugin_manager_(
           this,
-          "d::org.tizen.appfw.service.tizen_action_plugin_manager") {
-  model_ = model;
-}
+          "d::org.tizen.appfw.service.tizen_action_plugin_manager") {}
 
 PluginExecutor::~PluginExecutor() {
   if (connected_)

diff --git a/src/plugin-daemon/main.cc b/src/plugin-daemon/main.cc
index 19549dba25ae62fee91f12f187d96d2c81bd5a25..fc2815a8d64f3f9ad209ff463b148a4e58ba1fc3 100644 (file)
--- a/src/plugin-daemon/main.cc
+++ b/src/plugin-daemon/main.cc
@@ -37,7 +37,7 @@ class PluginService
   };
 
   PluginService(std::string sender, std::string instance)
-      : ServiceBase(sender, instance) {}
+      : ServiceBase(std::move(sender), std::move(instance)) {}
 
   void OnCreate() override {
     std::string sender = GetSender();