staging: vt6656: Use variable instead of its type in sizeof(...)
authorSimon Sandström <simon@nikanor.nu>
Fri, 30 Jun 2017 21:38:54 +0000 (23:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jul 2017 06:41:02 +0000 (08:41 +0200)
Use sizeof(variable) instead of sizeof(type) in memory allocations to
prevent problems if the variable type changes in the future.

Signed-off-by: Simon Sandström <simon@nikanor.nu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/main_usb.c

index 095b855..cc6d877 100644 (file)
@@ -419,8 +419,7 @@ static bool vnt_alloc_bufs(struct vnt_private *priv)
        int ii;
 
        for (ii = 0; ii < priv->num_tx_context; ii++) {
-               tx_context = kmalloc(sizeof(struct vnt_usb_send_context),
-                                    GFP_KERNEL);
+               tx_context = kmalloc(sizeof(*tx_context), GFP_KERNEL);
                if (!tx_context)
                        goto free_tx;
 
@@ -437,7 +436,7 @@ static bool vnt_alloc_bufs(struct vnt_private *priv)
        }
 
        for (ii = 0; ii < priv->num_rcb; ii++) {
-               priv->rcb[ii] = kzalloc(sizeof(struct vnt_rcb), GFP_KERNEL);
+               priv->rcb[ii] = kzalloc(sizeof(*priv->rcb[ii]), GFP_KERNEL);
                if (!priv->rcb[ii]) {
                        dev_err(&priv->usb->dev,
                                "failed to allocate rcb no %d\n", ii);