projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9c4f6be
)
scsi: wd719x: Call scsi_done() directly
author
Bart Van Assche
<bvanassche@acm.org>
Thu, 7 Oct 2021 20:46:05 +0000
(13:46 -0700)
committer
Martin K. Petersen
<martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:43 +0000
(21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.
Link:
https://lore.kernel.org/r/20211007204618.2196847-5-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/wd719x.c
patch
|
blob
|
history
diff --git
a/drivers/scsi/wd719x.c
b/drivers/scsi/wd719x.c
index
6f10a43
..
1a79475
100644
(file)
--- a/
drivers/scsi/wd719x.c
+++ b/
drivers/scsi/wd719x.c
@@
-200,7
+200,7
@@
static void wd719x_finish_cmd(struct wd719x_scb *scb, int result)
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
cmd->result = result << 16;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
}
/* Build a SCB and send it to the card */
@@
-295,7
+295,7
@@
out_unmap_scb:
DMA_BIDIRECTIONAL);
out_error:
cmd->result = DID_ERROR << 16;
-
cmd->
scsi_done(cmd);
+ scsi_done(cmd);
return 0;
}