drivers: staging : wlan-ng : collect return status without variable
authorHariprasad Kelam <hariprasad.kelam@gmail.com>
Sun, 12 May 2019 10:53:45 +0000 (16:23 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 May 2019 05:40:37 +0000 (07:40 +0200)
As caller rdev_set_default_key  not particular about -EFAULT.
We can preserve the return value of prism2_domibset_uint32.

Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
----
Changes in v2:
  - remove  masking of original return value with EFAULT
Changes in v3:
  - merge patch v1 and v2 sothat it can be applied on linux-next
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/cfg80211.c

index 8a862f7..eee1998 100644 (file)
@@ -231,17 +231,9 @@ static int prism2_set_default_key(struct wiphy *wiphy, struct net_device *dev,
 {
        struct wlandevice *wlandev = dev->ml_priv;
 
-       int err = 0;
-       int result = 0;
-
-       result = prism2_domibset_uint32(wlandev,
-               DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
-               key_index);
-
-       if (result)
-               err = -EFAULT;
-
-       return err;
+       return  prism2_domibset_uint32(wlandev,
+                                      DIDMIB_DOT11SMT_PRIVACYTABLE_WEPDEFAULTKEYID,
+                                      key_index);
 }
 
 static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,